feat: new rpc `gettxchainlocks' to get transaction statuses by batch by knst · Pull Request #5578 · dashpay/dash

knst · 2023-09-17T10:49:45Z

Issue being fixed or feature implemented

Requested by @QuantumExplorer for platform needs

What was done?

New rpc gettransactionsarelocked that returns list of txes.
it does less heavy calculations and transfer less data by gRPC.

How Has This Been Tested?

$ src/dash-cli gettransactionsarelocked  '["e469de7994b9c1da8efd262fee8843efd7bdcab80c700dc1059c98b28f7c5c1b", "0d9fdf00c9568ff9103742b64e6b8287794633072f8824fa2c475f59e71dbace","0d3f48eebead54d640a7fc5692ddfcba619d8b49347d9a7c04586057c02dec9f"]'

[
  {
    "height": 907801,
    "chainlock": true
  },
  {
    "height": 101,
    "chainlock": true
  },
  {
    "height": -1,
    "chainlock": false
  }
]

Limiter tested by this call:

src/dash-cli gettransactionsarelocked  '["", "","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","",""]'  | wc

Breaking Changes

N/A

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone

…. seems works

PastaPastaPasta · 2023-09-17T22:06:13Z

Based on the commit I pushed format is now

gettransactionsarelocked  '["e469de7994b9c1da8efd262fee8843efd7bdcab80c700dc1059c98b28f7c5c1b", "0d9fdf00c9568ff9103742b64e6b8287794633072f8824fa2c475f59e71dbace","0d3f48eebead54d640a7fc5692ddfcba619d8b49347d9a7c04586057c02dec9f"]'

[
  {
    "height": 907801,
    "chainlock": true
  },
  {
    "height": 101,
    "chainlock": true
  },
  {
    "height": -1,
    "chainlock": false
  }
]

src/rpc/rawtransaction.cpp

knst

utACK, thanks for simplifications @PastaPastaPasta

ogabrielides

LGTM

thephez

Will this RPC only return locked transactions? If so I'd propose naming the RPC getlockedtransactions. Or maybe gettransactionslockstatus if it also will return unlocked ones.

src/rpc/rawtransaction.cpp

UdjinM6

Now that the amount of returned data is reduced I think we should shrink the diff. Also fixed a couple of other things:

I don't like that we silently cut results
adjusted help text
proposing a different name.

Pls see 1f42ffe

src/rpc/client.cpp

src/rpc/rawtransaction.cpp

…k.py

thephez

utACK - help text and RPC name look better to me now 👍

PastaPastaPasta

utACK for squash merge

ogabrielides

utACK

src/rpc/rawtransaction.cpp

Co-authored-by: UdjinM6 <[email protected]>

UdjinM6

utACK

PastaPastaPasta

utACK for squash merge

Relates to dashpay/dash#5578

* docs(rpc): update protx diff Relates to dashpay/dash#5377 * docs(rpc): add getindexinfo rpc Relates to dashpay/dash#5492 * docs(rpc): add gettxchainlocks Relates to dashpay/dash#5578 * docs(rpc): update getblock

knst added 3 commits September 17, 2023 17:16

wip: draft 1

5f6cf64

cleanup

5cf3dc0

rename rpc to gettransactionsarelocked; clean up unused code and data…

d70235c

…. seems works

knst changed the title ~~new rpc getrawtransactions by batch~~ new rpc `gettransactionsarelocked' to get transaction statuses by batch Sep 17, 2023

knst added the RPC Some notable changes to RPC params/behaviour/descriptions label Sep 17, 2023

add limiter: no more than 100 txes in one request

b600162

knst marked this pull request as ready for review September 17, 2023 11:29

knst requested review from PastaPastaPasta, UdjinM6 and ogabrielides September 17, 2023 11:32

removed some extra fields that are not needed

2d89c9e

knst changed the title ~~new rpc `gettransactionsarelocked' to get transaction statuses by batch~~ feat: new rpc `gettransactionsarelocked' to get transaction statuses by batch Sep 17, 2023

avoid unneeded error states

58d820a

knst commented Sep 17, 2023

View reviewed changes

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved

knst commented Sep 17, 2023

View reviewed changes

ogabrielides previously approved these changes Sep 18, 2023

View reviewed changes

thephez reviewed Sep 18, 2023

View reviewed changes

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved

UdjinM6 requested changes Sep 18, 2023

View reviewed changes

PastaPastaPasta dismissed ogabrielides’s stale review via a51af6b September 18, 2023 14:18

UdjinM6 and others added 2 commits September 18, 2023 09:24

suggestions

74cc26f

minor refactoring

5b70143

PastaPastaPasta force-pushed the feature-getrawtransactions branch from a51af6b to 5b70143 Compare September 18, 2023 14:39

PastaPastaPasta requested review from UdjinM6 and thephez September 18, 2023 14:40

thephez requested changes Sep 18, 2023

View reviewed changes

knst added 4 commits September 19, 2023 08:57

fix: rename getttxchainlocks to gettxchainlocks

3208af4

fix: reduce scope of cs_main inside gettxchainlocks

cdf6ecd

refactor: adds couple of missing const in gettxchainlocks

454925d

feat: adds rpc_tests for gettxchainlocks

99a69c4

feat: adds functional tests for gettxchainlocks in rpc_verifychainloc…

d2be2cb

…k.py

thephez approved these changes Sep 19, 2023

View reviewed changes

PastaPastaPasta changed the title ~~feat: new rpc `gettransactionsarelocked' to get transaction statuses by batch~~ feat: new rpc `gettxchainlocks' to get transaction statuses by batch Sep 19, 2023

PastaPastaPasta previously approved these changes Sep 19, 2023

View reviewed changes

ogabrielides previously approved these changes Sep 19, 2023

View reviewed changes

UdjinM6 requested changes Sep 19, 2023

View reviewed changes

src/rpc/rawtransaction.cpp Show resolved Hide resolved

UdjinM6 added this to the 20 milestone Sep 19, 2023

Update src/rpc/rawtransaction.cpp

b1d0467

Co-authored-by: UdjinM6 <[email protected]>

knst dismissed stale reviews from ogabrielides and PastaPastaPasta via b1d0467 September 19, 2023 18:28

UdjinM6 approved these changes Sep 19, 2023

View reviewed changes

PastaPastaPasta approved these changes Sep 20, 2023

View reviewed changes

PastaPastaPasta merged commit 633cc32 into dashpay:develop Sep 20, 2023

thephez added a commit to thephez/docs-core that referenced this pull request Oct 3, 2023

docs(rpc): add gettxchainlocks

692dd72

Relates to dashpay/dash#5578

Conversation

knst commented Sep 17, 2023 • edited by PastaPastaPasta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

PastaPastaPasta commented Sep 17, 2023

Uh oh!

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

ogabrielides left a comment

Choose a reason for hiding this comment

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

ogabrielides left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

knst commented Sep 17, 2023 •

edited by PastaPastaPasta

Loading