test: getblockchaininfo projected activation_height test#5665
Merged
PastaPastaPasta merged 5 commits intodashpay:developfrom Nov 6, 2023
ogabrielides:activation_height_test
Merged
test: getblockchaininfo projected activation_height test#5665PastaPastaPasta merged 5 commits intodashpay:developfrom ogabrielides:activation_height_test
getblockchaininfo projected activation_height test#5665PastaPastaPasta merged 5 commits intodashpay:developfrom
ogabrielides:activation_height_test
Conversation
knst
reviewed
Nov 3, 2023
knst
reviewed
Nov 3, 2023
knst
reviewed
Nov 3, 2023
Co-authored-by: Konstantin Akimov <[email protected]>
Author
|
Would need to rebase if #5668 gets merged first. |
5 tasks
PastaPastaPasta
previously approved these changes
Nov 3, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
UdjinM6
requested changes
Nov 3, 2023
Author
makes sense |
ogabrielides
dismissed stale reviews from PastaPastaPasta and knst
via
6e563fb
PastaPastaPasta
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#5640
What was done?
Tests that
activation_heightprojected bygetblockchaininfoduring locked_in phase.Now, this test is only possible with v20 activation since v19, dip0024 are buried and mn_rr uses MNEF.
Enabled this test only in
feature_llmq_rotation.py.How Has This Been Tested?
tests
Breaking Changes
no
Checklist: