fix: use correct interruption condition in StartCachePopulatorThread#5732
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Nov 27, 2023
Merged
Conversation
broken since 4788
PastaPastaPasta
approved these changes
Nov 26, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge; but shouldn't we have a regression test for this?
Author
It's just a typo/copy-paste mistake in the preliminary cacheing logic. Not sure how we would test it.. Any suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#4788 (comment)
noticed while working on #5731
What was done?
How Has This Been Tested?
run a node, check logs - there is a meaningful time span between
startanddonenow and not just zeros all the time.Breaking Changes
Checklist: