fix: intermittent failure in feature_llmq_simplepose.py#5859
Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom Feb 7, 2024
Merged
fix: intermittent failure in feature_llmq_simplepose.py#5859PastaPastaPasta merged 2 commits intodashpay:developfrom
PastaPastaPasta merged 2 commits intodashpay:developfrom
Conversation
knst
force-pushed
the
fix-llmq-simplepose
branch
from
878bd28 to
9b6eb25
Compare
Collaborator
Author
|
@kwvg claims that with this patch it still fails randomly on his machine, but only 1/3 of failures compare to without patch. vs any ideas how we can improve this simplepose test futhermore? |
UdjinM6
requested changes
Feb 3, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
I don't see any improvement on my machine using this PR. Nodes drop connections on develop for no clear reason (no errors in logs). Simply waiting for connections did not help so I tried moving block generation out of the loop and suddenly d89f41c fixed the issue for me. But I don't understand how/why exactly... 🤷♂️ It would be nice if someone could explain why it worked 😄 Anyway, pls try this patch instead and share your thoughts.
Collaborator
Author
almost fixed for me, still one failure out of 20 which is pretty good @kwvg , can you test it, please? |
knst
force-pushed
the
fix-llmq-simplepose
branch
from
9b6eb25 to
ea0d064
Compare
Collaborator
|
|
I think I figured it out. Previously isolated nodes are trying to fetch blocks they missed as soon as they have a new connection open. When we bump mocktime 10+ minutes in the middle of that we trigger |
Collaborator
|
knst
force-pushed
the
fix-llmq-simplepose
branch
from
ea0d064 to
623c30d
Compare
PastaPastaPasta
approved these changes
Feb 7, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
kudos to kwvg to report issue: he pointed out that functional tests randomly fail lately.
Bisect pointed out an exact commit: bitcoin#20027 - mockable time everywhere
What was done?
Added call
mn.node.mockscheduleras it is done in 20027 for other functional testsHow Has This Been Tested?
Run 20 times. Without this patch 20% failures; with this patch - zero failures.
Breaking Changes
N/a
Checklist: