fix: actually run rpc_fundrawtransaction with and without HD feature#5907
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Mar 4, 2024
Merged
Conversation
Collaborator
Author
not sure if there's any value to backport to possible 20.0.5 because it doesn't fix wallet behavior but it fixes tests only. |
UdjinM6
requested changes
Feb 28, 2024
knst
force-pushed
the
hd-fix-rpc-fundtransaction
branch
from
f109b97 to
cc206dc
Compare
PastaPastaPasta
approved these changes
Feb 29, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Removed label; as I don't think a test fix makes sense to backport; otherwise utACK
PastaPastaPasta
force-pushed
the
hd-fix-rpc-fundtransaction
branch
from
cc206dc to
a392be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Due to double initialization of
extra_argsrpc_fundrawtransaction always test with enabled or disabled HD wallets (which is enabled by default).What was done?
Fixes double initialization and inversion of condition due to hd wallets enabled by default since #5807
How Has This Been Tested?
Run functional tests and watch
ps auxduring running to ensure that-usehdis set properly.Breaking Changes
N/A
Checklist: