trivial: remove unneeded header, enumerate circular dependencies#5941
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Mar 18, 2024
Merged
trivial: remove unneeded header, enumerate circular dependencies#5941PastaPastaPasta merged 1 commit intodashpay:developfrom
PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
As found in a review comment in dashpay#5908[1], validation.h is not needed for specialtxman.cpp and removing the header uncovers other circular dependencies that were obscured by the shortest circular path[2]. [1] - dashpay#5929 (comment) [2] - dashpay#5929 (comment)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
As found in #5929 (comment),
validation.his not needed forspecialtxman.cppand removing the header uncovers other circular dependencies that were obscured by the shortest circular path (see #5929 (comment)).Breaking Changes
None.
Checklist: