fix: optimize compilation time of gsl library#6039
Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom Aug 29, 2024
Merged
fix: optimize compilation time of gsl library#6039PastaPastaPasta merged 2 commits intodashpay:developfrom
PastaPastaPasta merged 2 commits intodashpay:developfrom
Conversation
5 tasks
|
Let's wait for the upstream PR to be merged first |
Collaborator
Author
for reference: microsoft/GSL#1153 |
Collaborator
Author
|
@PastaPastaPasta @UdjinM6 let's get this one merged. I compile Dash every day on laptop and extra 10 seconds off compilation time for clean build is a noticeable improvement for me. I will create follow-up PR once that one is merged (if any difference to merge): microsoft/GSL#1153 |
|
pls rebase |
We do not use this feature and implementation is trivial: just call `get()`
it removes: - algorithm: `forward` is a part of utility not algorithm - system_error: `hash` is already declared in memory
1d79221 to
dc59cbc
Compare
UdjinM6
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This header
gsl/pointers.his included in multiple other headers all over codebase.Any extra line of code inside gsl/pointers.h makes all project to compile slower.
What was done?
Removed headers
<algorithm>,<system_error>,<iosfwd>from gsl/pointers.hHow Has This Been Tested?
Run command 5 times, takes minimum time:
as a result, overall project compilation time is also improved:
make clean ; sleep 3s ; time make -j20Breaking Changes
N/A
Checklist: