backport: merge bitcoin#21879, #23604, #24357, #25426, #24378 (sockets backports)#6054
Merged
PastaPastaPasta merged 5 commits intodashpay:developfrom Jun 12, 2024
Merged
backport: merge bitcoin#21879, #23604, #24357, #25426, #24378 (sockets backports)#6054PastaPastaPasta merged 5 commits intodashpay:developfrom
PastaPastaPasta merged 5 commits intodashpay:developfrom
Conversation
…tsockname() and use it in GetBindAddress()
knst
reviewed
Sep 10, 2024
src/net.cpp
Outdated
| for (ListenSocket& hListenSocket : vhListenSocket) { | ||
| if (hListenSocket.socket != INVALID_SOCKET) { | ||
| if (m_edge_trig_events && !m_edge_trig_events->RemoveSocket(hListenSocket.socket)) { | ||
| if (hListenSocket.sock->Get() != INVALID_SOCKET) { |
Collaborator
There was a problem hiding this comment.
why these lines are not removed? I am going to prepare PR with fix
Collaborator
Author
There was a problem hiding this comment.
Because we iterate through them to remove them from the ETE list, the kernel needs to be notified before the socket gets destroyed.
Lines 3763 to 3769 in 0c243ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
CConnman::SocketEvents()with mockableSock::WaitMany()), implementSock::WaitMany{Epoll,KQueue}()#6018Breaking Changes
None expected.
Checklist: