backport: Merge bitcoin#22619, 22593#6071
Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom Aug 28, 2024
Merged
Conversation
vijaydasmp
changed the title
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_98
branch
3 times, most recently
from
d1bf903 to
969a9ed
Compare
|
This pull request has conflicts, please rebase. |
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_98
branch
4 times, most recently
from
38bf780 to
bb5cfcc
Compare
vijaydasmp
force-pushed
the
bp23_98
branch
6 times, most recently
from
e5bc737 to
0020e72
Compare
vijaydasmp
changed the title
Author
|
Hello @UdjinM6 , @knst , @PastaPastaPasta for review |
knst
reviewed
Jul 23, 2024
doc/release-notes-22570.md
Outdated
Collaborator
There was a problem hiding this comment.
22570 has been already released with version Dash Core v20: #5574
without release notes, too late to update it now.
DNM 22603
vijaydasmp
changed the title
UdjinM6
previously approved these changes
Aug 5, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
utACK 26ec2e4a14045291c96c7e2dc04db9c318599977
|
This pull request has conflicts, please rebase. |
Author
had to rebase , requesting re-review |
vijaydasmp
force-pushed
the
bp23_98
branch
2 times, most recently
from
86fb13f to
431a82f
Compare
vijaydasmp
force-pushed
the
bp23_98
branch
2 times, most recently
from
16c39fe to
f9bfc35
Compare
UdjinM6
requested changes
Aug 21, 2024
UdjinM6
approved these changes
Aug 22, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
utACK a6ec9bcc3793e0579ee039a204c6d971cfbc797e
Author
|
Hello @PastaPastaPasta, requesting review |
…ing conversion in functional test framework 5a1bef6 test: refactor: remove binascii from test_framework (Zero-1729) Pull request description: This PR continues the work started in PR bitcoin#22593, regarding using the `bytes` built-in module. In this PR specifically, instances of `binascii`'s methods `hexlify`, `unhexlify`, and `a2b_hex` have been replaced with the build-in `bytes` module's `hex` and `fromhex` methods where appropriate to make bytes <-> hex-string conversions consistent across the functional test files and test_framework. Additionally, certain changes made are based on the following assumption: ``` bytes.hex(data) == binascii.hexlify(data).decode() bytes.hex(data).encode() == binascii.hexlify(data) ``` Ran the functional tests to ensure behaviour is still consistent and changes didn't break existing tests. closes bitcoin#22605 ACKs for top commit: theStack: Code-review ACK 5a1bef6 🔢 Tree-SHA512: 8f28076cf0580a0d02a156f3e1e94c9badd3d41c3fbdfb2b87cd8a761dde2c94faa5f4c448d6747b1ccc9111c3ef1a1d7b42a11c806b241fa0410b7529e2445f Signed-off-by: Vijay <[email protected]>
Signed-off-by: Vijay <[email protected]>
knst
approved these changes
Aug 27, 2024
kwvg
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bitcoin backports