test: fix test of withdrawal for more than 1000 dash#6141
Merged
PastaPastaPasta merged 3 commits intodashpay:developfrom Aug 5, 2024
Merged
test: fix test of withdrawal for more than 1000 dash#6141PastaPastaPasta merged 3 commits intodashpay:developfrom
PastaPastaPasta merged 3 commits intodashpay:developfrom
Conversation
UdjinM6
requested changes
Jul 23, 2024
UdjinM6
approved these changes
Jul 23, 2024
UdjinM6
left a comment
There was a problem hiding this comment.
ACK 4f0f22ddec5738aac61c89ea11b67c06fe7c4ded
5 tasks
PastaPastaPasta
approved these changes
Aug 2, 2024
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK 4f0f22ddec5738aac61c89ea11b67c06fe7c4ded; only changes tests
bcdb696 to
2d2c05a
Compare
|
rebased via GH GUI to fix "Check Merge Fast-Forward Only" |
Member
|
It's now not signed so I can't merge it ;) |
|
well, that's better than merging a broken one anyway :D |
Now function test doesn't distint difference between 10% or 1000. Adjust amounts to make it less than 10% but more than 1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
DIP for Credit Pool says:
Though, current functional test for asset locks improperly test this case, because threshold for big withdrawal happens by 10%, not 1000 dash.
What was done?
Improvements for functional asset lock test to actually test a limit 1000 dash, not just 10%
How Has This Been Tested?
See changes
Breaking Changes
N/A, changes only for tests
Checklist: