fix: build with -Wdocumentation - rename param pwallet to wallet#6142
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Jul 23, 2024
Merged
fix: build with -Wdocumentation - rename param pwallet to wallet#6142PastaPastaPasta merged 1 commit intodashpay:developfrom
PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
It happened due to 2 PRs merged one after each other without rebasing: - enabling -Wdocumentation in bitcoin#21631 (dashpay#6113) - renaming param while doxygen comment is forgotten in dashpay#6114
UdjinM6
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
CI failures like that:
https://gitlab.com/dashpay/dash/-/jobs/7400661581
It happened due to 2 PRs merged one after each other without rebasing:
What was done?
It contains changes from #6133
Thanks Vijay for spotting issue, this PR is DNM if 6133 will get merged faster.
How Has This Been Tested?
See CI
Breaking Changes
N/A
Checklist: