chore: update seeds for v21 release#6151
Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom Jul 24, 2024
Merged
Conversation
contrib/seeds/README.md
Outdated
Member
There was a problem hiding this comment.
you should be specifying specific block here?
Collaborator
Author
There was a problem hiding this comment.
nope, by default it's "current tip"
Member
There was a problem hiding this comment.
Yeah... Arguably we should be specifying a specific hash though so it's more reproducible
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| dash-cli protx list valid 1 > protx_list.json | |
| dash-cli protx list valid 1 _TIP_ > protx_list.json |
?
There was a problem hiding this comment.
You have to pick a specific block to make it reproducible. Could change that rpc to accept block hashes but specifying block height is good enough if that block is chainlocked already.
Member
There was a problem hiding this comment.
Idk, it's probably fine. We've had trouble actually reproducing these before
PastaPastaPasta
previously approved these changes
Jul 24, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK 133fc20cb384dd2d027baed53d7ab011bf084e07
UdjinM6
requested changes
Jul 24, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Should revert changes in contrib/seeds/README.md imo, they are both irrelevant and incorrect
Member
|
Sooo what was the height you used? :) |
Collaborator
Author
|
Member
|
Unable to reproduce, I believe due to local issue: |
UdjinM6
reviewed
Jul 24, 2024
contrib/seeds/README.md
Outdated
Comment on lines
6
to
9
There was a problem hiding this comment.
The note above is not accurate too actually, it must be a list from a "safe" block, not a "current" one. I'd still prefer to revert these changes and fix it in a separate PR.
Collaborator
Author
There was a problem hiding this comment.
I doesn't like hard-coded 2018966 because it's easy to copy-paste and use same 2018966 for next time.
There was a problem hiding this comment.
I agree but this PR is a wrong place to fix it
|
I'm getting lots of |
Collaborator
Author
I got 698 failures: |
```sh dash-cli protx list valid 1 2110129 > protx_list.json while IFS= read -r line do address=$(echo $line | cut -d':' -f1) port=$(echo $line | cut -d':' -f2) nc -v -x 127.0.0.1:9050 -z $address $port done < "onion_seeds.txt" python3 makeseeds.py protx_list.json onion_seeds.txt > nodes_main.txt python3 generate-seeds.py . > ../../src/chainparamsseeds.h ```
UdjinM6
approved these changes
Jul 24, 2024
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2024
43c3953 chore: update seeds (Konstantin Akimov) 16dd043 chore: added extra onion seeds (provided by pasta) (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented dashpay#6081 ## What was done? Extra onion seeds are provided by pasta. ```sh dash-cli protx list valid 1 2110129 > protx_list.json # Make sure the onion seeds still work! while IFS= read -r line do address=$(echo $line | cut -d':' -f1) port=$(echo $line | cut -d':' -f2) nc -v -x 127.0.0.1:9050 -z $address $port done < "onion_seeds.txt" python3 makeseeds.py protx_list.json onion_seeds.txt > nodes_main.txt python3 generate-seeds.py . > ../../src/chainparamsseeds.h ``` ## How Has This Been Tested? n/a ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 43c3953 PastaPastaPasta: utACK dashpay@43c3953 Tree-SHA512: 8583f030949c6b26b5410eaa4db4f9b85fbe14bc147083861519d9564ae1fff52716b2d8deb233d30ecfb679e778cb2bb2f0ef3dee392cff1986b004b03d9e1e
PastaPastaPasta
added a commit
that referenced
this pull request
Jul 25, 2024
cd0a3a6 Merge #6154: chore: remove trailing whitespaces in release notes (pasta) 6bc60a7 Merge #6151: chore: update seeds for v21 release (pasta) 88e949a Merge #6146: chore: bump assumevalid, minchainwork, checkpoints, chaintxdata (pasta) cc14427 Merge #6144: docs: release notes for v21.0.0 (pasta) 0a8ece1 Merge #6122: chore: translations 2024-07 (pasta) 146d244 Merge #6140: feat: harden all sporks on mainnet to current values (pasta) 024d272 Merge #6126: feat: enable EHF activation of MN_RR on mainnet (pasta) e780b3d Merge #6125: docs: update manpages for 21.0 (pasta) 5ede23c Merge #6118: docs: add release notes notifying change of default branch to `develop` (pasta) 1b6fe9c Merge #6117: docs: update supported versions in SECURITY.md (pasta) 27d20be Merge #6116: fix: mitigate crashes associated with some upgradetohd edge cases (pasta) Pull request description: ## Issue being fixed or feature implemented Backports to v21 for rc.3; there are more PRs to be back ported here ## What was done? see commits ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK cd0a3a6 Tree-SHA512: 0a8d027c5952fcb61317cc413a0de1f3152ae675c5690942400c3e4655cc6a803c702a7e1b18d8dac77aa0f483783f5cdbe29d6c0592165c4f0517d6f37b91a4
PastaPastaPasta
added a commit
that referenced
this pull request
Jul 29, 2024
98a3393 chore: set release to true (pasta) cd0a3a6 Merge #6154: chore: remove trailing whitespaces in release notes (pasta) 6bc60a7 Merge #6151: chore: update seeds for v21 release (pasta) 88e949a Merge #6146: chore: bump assumevalid, minchainwork, checkpoints, chaintxdata (pasta) cc14427 Merge #6144: docs: release notes for v21.0.0 (pasta) 0a8ece1 Merge #6122: chore: translations 2024-07 (pasta) 146d244 Merge #6140: feat: harden all sporks on mainnet to current values (pasta) 024d272 Merge #6126: feat: enable EHF activation of MN_RR on mainnet (pasta) e780b3d Merge #6125: docs: update manpages for 21.0 (pasta) 5ede23c Merge #6118: docs: add release notes notifying change of default branch to `develop` (pasta) 1b6fe9c Merge #6117: docs: update supported versions in SECURITY.md (pasta) 27d20be Merge #6116: fix: mitigate crashes associated with some upgradetohd edge cases (pasta) db82817 Merge #6106: feat: create new composite quorum-command platformsign (pasta) a45e6df Merge #6104: fix: adjust incorrect parameter description that says there is a default that doesn't exist (pasta) 7330982 Merge #6100: feat: make whitelist works with composite commands for platform needs (pasta) 9998ffd Merge #6096: feat: split type of error in submitchainlock - return enum in CL verifying code (pasta) cdf7a25 Merge #6095: fix: createwallet to require 'load_on_startup' for descriptor wallets (pasta) c1c2c55 Merge #6092: fix: mixing for partially unlocked descriptor wallets (pasta) 1175486 Merge #6073: feat: add logging for RPC HTTP requests: command, user, http-code, time of running (pasta) Pull request description: ## Issue being fixed or feature implemented Suppressed changes from be83865 so the diff is empty. ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: ACK 158cf86; no diff knst: ACK 158cf86 Tree-SHA512: 3310a39fbcb45bdf09f885fe77ba769c0a715869a3bb287eaf0f2cf54b35a7e1f832c88df3bd31097eabf2d375515c1b87ff05e0c3282cef642833a154c42bbe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#6081
What was done?
Extra onion seeds are provided by pasta.
How Has This Been Tested?
n/a
Breaking Changes
n/a
Checklist: