refactor: drop some of circular dependencies over dkgsession#6282
Merged
PastaPastaPasta merged 11 commits intodashpay:developfrom Sep 25, 2024
Merged
refactor: drop some of circular dependencies over dkgsession#6282PastaPastaPasta merged 11 commits intodashpay:developfrom
PastaPastaPasta merged 11 commits intodashpay:developfrom
Conversation
|
This pull request has conflicts, please rebase. |
knst
force-pushed
the
refactor-exclude-evo-h
branch
from
af64e15 to
d2bced3
Compare
knst
force-pushed
the
refactor-exclude-evo-h
branch
from
d2bced3 to
74a5a9f
Compare
UdjinM6
approved these changes
Sep 24, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We have 72 circular dependencies of dash specific code. This PR removes 2 of them, over dkgsession.
What was done?
Refactor dkgsession initialization, message processing, dropped unused arguments, re-distributed code between functions and modules... See each commit.
Also optimized headers: excluded evo/evodb.h and llmq/quorums.h from the headers where they are not needed.
How Has This Been Tested?
Run
test/lint/lint-circular-dependencies.shRun unit/functional tests
Breaking Changes
N/A
Checklist: