backport: merge bitcoin#23156, #23213, #23227, #23223, #23564, #23538, #23437, #23630, #23465, #23738, #17631, #22875 (auxiliary backports: part 18)#6297
Merged
PastaPastaPasta merged 13 commits intodashpay:developfrom Oct 8, 2024
Conversation
|
This pull request has conflicts, please rebase. |
kwvg
changed the title
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
previously approved these changes
Oct 8, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
LGTM 328b14ad8df9155b2a9f37a8fe17ad0981686072 but I'd prefer 0eac8b58965f8def5fd2663f56c8b3b1c36ce670 be non-partial
This is required in order to backport bitcoin#23156, which gets rid of `ParseDouble` (used by `ParseDoubleV`), which is last used by `quorum dkgsimerror`.
kwvg
changed the title
knst
reviewed
Oct 8, 2024
| #include <univalue.h> | ||
|
|
||
| static const size_t MAX_GETUTXOS_OUTPOINTS = 15; //allow a max of 15 outpoints to be queried at once | ||
| static constexpr unsigned int MAX_REST_HEADERS_RESULTS = 2000; |
Collaborator
There was a problem hiding this comment.
should it be different amount of COMPRESSED headers? @PastaPastaPasta
UdjinM6
approved these changes
Oct 8, 2024
knst
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
Dependent on backport: merge bitcoin#22741, #22788, #23207, #23300, partial bitcoin#22550 (moving
generate*to TestFramework) #6288Dependent on backport: merge bitcoin#22772, #22987, #23185, #23157, #23173, #23249, #23211, #22677, #23649, #23683, #23636, #22626 (auxiliary backports: part 17) #6296
Breaking changes
quorum dkgsimerrorwill no longer accept a decimal value between 0 and 1 for therateargument, it will now expect an integer between 0 to 100.Checklist