fix: multiple minor errors for Dash Core pre v22#6373
Merged
PastaPastaPasta merged 8 commits intodashpay:developfrom Oct 29, 2024
Merged
fix: multiple minor errors for Dash Core pre v22#6373PastaPastaPasta merged 8 commits intodashpay:developfrom
PastaPastaPasta merged 8 commits intodashpay:developfrom
Conversation
knst
force-pushed
the
multiple-fixes-2024-10-p1
branch
from
fe559d2 to
2aff47c
Compare
knst
changed the title
… get payees for block at height"
[httpworker.0] [masternode/payments.cpp:116] [IsTransactionValid] CMNPaymentsProcessor::IsTransactionValid -- ERROR! Failed to get payees for block at height 110
[httpworker.0] [masternode/payments.cpp:278] [IsBlockPayeeValid] CMNPaymentsProcessor::IsBlockPayeeValid -- Valid masternode payment at height 110: CTransaction(hash=837e35fab5, ver=3, type=5, vin.size=1, vout.size=1, nLockTime=0, vExtraPayload.size=70)
CTxIn(COutPoint(0000000000000000000000000000000000000000000000000000000000000000, 4294967295), coinbase 016e0101)
CTxOut(nValue=500.00000000, scriptPubKey=76a9148708dff2bf8b31363cb4201d)
…ssage in logs
exmple of error during first start of dashd:
[ init] [util/system.h:57] [error] ERROR: CoreRead: Failed to open file DASH/node0/regtest/governance.dat
On CI it is not critical, because there are only 4-8 parallel jobs, while locally it can be 12-20 or even more
knst
force-pushed
the
multiple-fixes-2024-10-p1
branch
from
2aff47c to
2026c59
Compare
UdjinM6
approved these changes
Oct 29, 2024
kwvg
reviewed
Oct 29, 2024
|
|
||
| LogPrintf("Writing info to %s...\n", strFilename); | ||
| CoreWrite(objToSave); | ||
| const bool ret = CoreWrite(objToSave); |
Collaborator
There was a problem hiding this comment.
We should probably not print "dump finished" if ret is false
Collaborator
Author
There was a problem hiding this comment.
that log is for benchmark purposes, but I am ready to apply suggestions
| } | ||
|
|
||
| auto dmnPayee = m_dmnman.GetListForBlock(pindexPrev).GetMNPayee(pindexPrev); | ||
| const auto mnList = m_dmnman.GetListForBlock(pindexPrev); |
Collaborator
Author
There was a problem hiding this comment.
it's not a crash and even not a failure. It is not expecting ERROR strings in logs on Regtest for every block since DIP0003 is activated but no masternodes created.
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
generally LGTM 2026c59; one question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
It fixes several minor issues:
error messages in logs on regtest:
error messages for non-existing files for first run:
non-dashified
bitcoin-cliindoc/JSON-RPC-interface.mdincorrect initialization of
CMerkleBlockin functional tests which can cause an un-explainable failureuse random ports for
interface_zmq_dash.pyto let tests run simultaneouslyfix missing todo about using
sethdseedafter backport: bitcoin#18836, #19046, #19490, #20403, #21127, #21238, #21329 - descriptor wallets part V & sethdseed #6017optimization of local run of functional tests (slowest go first)
What was done?
See each commit
How Has This Been Tested?
Run unit/functional tests
Breaking Changes
N/A
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.