test: improve mine rotation quorums for IS in functional tests#6431
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Dec 4, 2024
Merged
test: improve mine rotation quorums for IS in functional tests#6431PastaPastaPasta merged 1 commit intodashpay:developfrom
PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
d8e1ccd to
f8cfda6
Compare
PastaPastaPasta
approved these changes
Dec 3, 2024
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK f8cfda6; I wish that is_first could be automatically detected instead of manually set.
UdjinM6
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Mining rotation quorum currently is not trivial. All over a codebase used this template to get a rotating quorum:
The performance of this code is not great also because generating 3 or 4 batches of blocks requires time to sync nodes after each batch.
What was done?
This PR move instantly to 3-4 DKG sessions forward and starts from cycling quorum.
It's only one cycling quorum (instant-send), so, extra params are also removed.
To get it just call:
How Has This Been Tested?
Run unit and functional tests
By my benchmark it gives roughly 10 seconds for each functional test that uses rotation quorum.
Breaking Changes
N/A
Checklist: