refactor: Introduce LogAcceptDebug() which is LogAcceptCategory() with Debug level#6436
Merged
PastaPastaPasta merged 3 commits intodashpay:developfrom Dec 6, 2024
Merged
refactor: Introduce LogAcceptDebug() which is LogAcceptCategory() with Debug level#6436PastaPastaPasta merged 3 commits intodashpay:developfrom
LogAcceptDebug() which is LogAcceptCategory() with Debug level#6436PastaPastaPasta merged 3 commits intodashpay:developfrom
Conversation
knst
reviewed
Nov 29, 2024
UdjinM6
changed the title
LogAcceptCategory() to Debug by defaultLogAcceptDebug() which is LogAcceptCategory() with Debug level
knst
reviewed
Nov 29, 2024
knst
previously approved these changes
Nov 29, 2024
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
utACK c62b35c7aec0a1d9338b817885414c8dfb51002d
kwvg
previously approved these changes
Dec 2, 2024
Collaborator
kwvg
left a comment
kwvg
left a comment
There was a problem hiding this comment.
utACK c62b35c7aec0a1d9338b817885414c8dfb51002d
Author
|
NOTE: we should merge #6441 first to avoid backport conflicts (will rebase this PR later) |
Member
|
Marked as draft so I don't merge |
|
This pull request has conflicts, please rebase. |
Member
|
Range diff looks good; gonna merge |
kwvg
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#6399 introduced severity-based logging via b046e09. We use
LogAcceptCategory()in quite a few places and it's alwaysBCLog::Level::Debugso log level is kind of redundant for us and just makes it harder to read the code.What was done?
Set log level in. IntroduceLogAcceptCategory()toBCLog::Level::Debugby defaultLogAcceptDebug()which isLogAcceptCategory()withDebuglevel. Simplify corresponding Dash-specific code.How Has This Been Tested?
Breaking Changes
n/a
Checklist: