refactor: pass CWallet reference to CTransactionBuilder#6449
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Dec 10, 2024
Merged
refactor: pass CWallet reference to CTransactionBuilder#6449PastaPastaPasta merged 1 commit intodashpay:developfrom
PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
knst
force-pushed
the
refactor-ctransactionbuilder
branch
from
d7daf4d to
43778b0
Compare
UdjinM6
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Follow-up for #6441
What was done?
Pass reference to CWallet instead const reference to smart pointer with CWallet to CTransactionBuilder.
How Has This Been Tested?
Run unit/functional tests
Breaking Changes
N/A
Checklist: