ci: merge bitcoin#27314, #28954, fix multiprocess builds#6491
Merged
PastaPastaPasta merged 5 commits intodashpay:developfrom Dec 17, 2024
Merged
ci: merge bitcoin#27314, #28954, fix multiprocess builds#6491PastaPastaPasta merged 5 commits intodashpay:developfrom
PastaPastaPasta merged 5 commits intodashpay:developfrom
Conversation
UdjinM6
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
bitcoin#27314 has been backported in this PR as bitcoin#25838 (backported in dash#6384) broke Clang depends builds.
bitcoin#28954 has been backported to fix a problem associated with multiprocess runs (build).
Support for multiprocess builds were enabled proper in dash#6143 but unfortunately, the configuration params for multiprocess builds were not processed by CI as the build variant was not added to
matrix.sh(source). This is evident by comparing two variants with Boost::Process enablement (--with-boost-process),linux64_fuzz(source) andlinux64_multiprocess(source).Looking at a
develop(6a51ab2) build, the fuzz build has it enabled (source) while the multiprocess build doesn't (source) despite both scripts having the enablement argument.Breaking Changes
None expected.
Checklist: