Skip to content

fix(qt): update CoinJoin frame and tx list on client model update#6565

Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:6541_fu
Feb 12, 2025
Merged

fix(qt): update CoinJoin frame and tx list on client model update#6565
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:6541_fu

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 10, 2025

Issue being fixed or feature implemented

3f9dca5 (#6541) broke Overview Page.

Wallet model is set earlier now (via WalletView ctor and not via addWallet 3f9dca5#diff-c0330db51c25c4bb621fca0b908dc6fc597db2077f74855eed1b16e0739748a6L88) but we need Client model too to call updateAdvancedCJUI() correctly and it's not yet available.

What was done?

Move updateAdvancedCJUI() call to setClientModel().

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 23 milestone Feb 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2025

Walkthrough

The changes modify the update behavior of the CoinJoin interface in the OverviewPage class. In the setClientModel method, an explicit update call is added to refresh the CoinJoin frame and transaction list based on the client's configuration. This call passes the current setting of the advanced CoinJoin UI option from the model's options. Conversely, in the setWalletModel method, the previously included update call has been removed. No method signatures have been changed; only the internal functionality concerning when and how the CoinJoin interface is updated has been altered.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8e6b92 and 716cb3e.

📒 Files selected for processing (1)
  • src/qt/overviewpage.cpp (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build Dependencies (linux64, x86_64-pc-linux-gnu)
  • GitHub Check: Build Dependencies (arm-linux, arm-linux-gnueabihf)
🔇 Additional comments (1)
src/qt/overviewpage.cpp (1)

302-303: LGTM! The fix correctly ensures client model availability.

The change properly addresses the issue by moving the UI update to setClientModel, ensuring the client model is available when updating the CoinJoin frame and transaction list.

Let's verify that this is the only place where updateAdvancedCJUI is called with a direct model access:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for all calls to updateAdvancedCJUI
rg -A 2 'updateAdvancedCJUI'

Length of output: 1184

LGTM! Client model update is correctly handled.

  • The explicit call to updateAdvancedCJUI(model->getOptionsModel()->getShowAdvancedCJUI()) is now in the intended location, ensuring the client model is available.
  • The remaining usage via the signal-slot connection (triggered by AdvancedCJUIChanged) is appropriate and confirms that the UI is updated dynamically when options change.
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PastaPastaPasta PastaPastaPasta requested a review from kwvg February 11, 2025 01:39
PastaPastaPasta
PastaPastaPasta approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 716cb3e

kwvg
kwvg approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 716cb3e

@PastaPastaPasta PastaPastaPasta merged commit f11c16f into dashpay:develop Feb 12, 2025
19 of 21 checks passed
@UdjinM6
Copy link
Author

UdjinM6 commented Feb 14, 2025

#6541 and this follow-up are for v23, removed backport-candidate-22.1.x label

@UdjinM6 UdjinM6 mentioned this pull request Feb 21, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@kwvg kwvg kwvg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

23

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6 @PastaPastaPasta @kwvg