fix: Reset all collections before reading in `CDeterministicMNListDiff::Unserialize()` by UdjinM6 · Pull Request #6814 · dashpay/dash

UdjinM6 · 2025-08-11T19:08:53Z

Issue being fixed or feature implemented

Fix the issue found by @coderabbitai while reviewing #6813 #6813 (review)

What was done?

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

…f::Unserialize()`

github-actions · 2025-08-11T19:09:26Z

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

feat: Migrate CDeterministicMNStateDiff to a new format with nVersion being the first bit to read #6813 - feat: Migrate CDeterministicMNStateDiff to a new format with nVersion being the first bit to read

Please coordinate with the authors of these PRs to avoid merge conflicts.

coderabbitai · 2025-08-11T19:14:45Z

Walkthrough

A single change in src/evo/deterministicmns.h modifies CDeterministicMNListDiff::Unserialize(Stream& s) to explicitly clear addedMNs before reading, with a comment indicating resetting all collections prior to deserialization. This aligns addedMNs with existing resets for updatedMNs and removedMns. The rest of the deserialization logic (reading addedMNs, updatedMNs, removedMns from the stream) remains unchanged. No exported/public signatures were altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55fd182 and 8e0e63f.

📒 Files selected for processing (1)

src/evo/deterministicmns.h (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/**/*.{cpp,h,cc,cxx,hpp}

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/**/*.{cpp,h,cc,cxx,hpp}: Dash Core C++ codebase must be written in C++20 and require at least Clang 16 or GCC 11.1
Dash uses unordered_lru_cache for efficient caching with LRU eviction

Files:

src/evo/deterministicmns.h

src/{masternode,evo}/**/*.{cpp,h,cc,cxx,hpp}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Masternode lists must use immutable data structures (Immer library) for thread safety

Files:

src/evo/deterministicmns.h

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: x86_64-w64-mingw32 / Build depends
GitHub Check: Lint / Run linters
GitHub Check: x86_64-pc-linux-gnu_multiprocess / Build depends
GitHub Check: x86_64-apple-darwin / Build depends
GitHub Check: x86_64-pc-linux-gnu_nowallet / Build depends
GitHub Check: arm-linux-gnueabihf / Build depends
GitHub Check: x86_64-pc-linux-gnu / Build depends

🔇 Additional comments (1)

src/evo/deterministicmns.h (1)

543-544: Good defensive programming practice!

Adding addedMNs.clear() ensures consistent behavior with the other collections (updatedMNs and removedMns) and prevents potential issues with residual data from previous deserializations.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

knst

LGTM 8e0e63f

kwvg

utACK 8e0e63f

kwvg · 2025-08-13T15:18:04Z

src/evo/deterministicmns.h

    void Unserialize(Stream& s)
    {
+        // Reset all collections before reading
+        addedMNs.clear();


nit: Could be in a Clear() function like CDeterministicMNList (source) but non-blocker

fix: Reset all collections before reading in `CDeterministicMNListDif…

8e0e63f

…f::Unserialize()`

UdjinM6 added this to the 23 milestone Aug 11, 2025

knst approved these changes Aug 13, 2025

View reviewed changes

kwvg approved these changes Aug 13, 2025

View reviewed changes

github-actions bot mentioned this pull request Aug 13, 2025

feat: Migrate CDeterministicMNStateDiff to a new format with nVersion being the first bit to read #6813

Merged

5 tasks

PastaPastaPasta merged commit d7319b6 into dashpay:develop Aug 13, 2025
31 of 34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Reset all collections before reading in `CDeterministicMNListDiff::Unserialize()`#6814

fix: Reset all collections before reading in `CDeterministicMNListDiff::Unserialize()`#6814
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:fix_dmnldiff_deser

UdjinM6 commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

coderabbitai bot commented Aug 11, 2025

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

knst left a comment

Uh oh!

kwvg left a comment

Uh oh!

kwvg Aug 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

UdjinM6 commented Aug 11, 2025

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

github-actions bot commented Aug 11, 2025

⚠️ Potential Merge Conflicts Detected

Uh oh!

coderabbitai bot commented Aug 11, 2025

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

kwvg left a comment

Choose a reason for hiding this comment

Uh oh!

kwvg Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)