Skip to content

depends: update 'src/dashbls' to dashpay/bls-signatures@dd683653 as e686744e#6891

Merged
PastaPastaPasta merged 4 commits intodashpay:developfrom
kwvg:bump_bls_1.3.6
Oct 14, 2025
Merged

depends: update 'src/dashbls' to dashpay/bls-signatures@dd683653 as e686744e#6891
PastaPastaPasta merged 4 commits intodashpay:developfrom
kwvg:bump_bls_1.3.6

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Oct 14, 2025

Additional Information

Breaking Changes

None expected.

Checklist:

  • I have performed a self-review of my own code (note: N/A)
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

kwvg added 4 commits October 14, 2025 22:53
@kwvg
revert: stop tracking cmake dependency relic_conf.h.in
b820266 
reverts:
- 02260cb.
@kwvg
Squashed 'src/dashbls/' changes from 0bb5c5b032..dd683653c6
e686744 
dd683653c6 Merge pull request dashpay#115 from kwvg/bump_1.3.6
f5dc3d0a87  chore: bump version to 1.3.6
3a2208ecc3 Merge pull request dashpay#114 from kwvg/bye_ssp
6e0a611212 build: remove explicit libssp linking from Windows build
d5e656f707 chore: update cmake (dashpay#113)
02fc11abfd ci: use ubuntu-latest instead of 20.04 as actions is EOLing 20.04 (dashpay#109)

git-subtree-dir: src/dashbls
git-subtree-split: dd683653c6eaba7235bc9c600f46bafbb8210291
@kwvg
depends: update 'src/dashbls' to dashpay/bls-signatures@dd683653 as e…
98b0807 
…686744
@kwvg
build: stop tracking cmake dependency relic_conf.h.in
b31fd98
@kwvg kwvg added this to the 23 milestone Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

Please coordinate with the authors of these PRs to avoid merge conflicts.

@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

  • CI: GitHub Actions workflow switches OS matrix entry from ubuntu-20.04 to ubuntu-latest.
  • Build/config: libdashbls package version updated from 1.3.5 to 1.3.6 in configure.ac.
  • Hardening: Removed MinGW-specific libssp presence check from configure.ac.
  • CMake: Increased minimum required version to 3.14 in depends/mimalloc/CMakeLists.txt and depends/mimalloc/test/CMakeLists.txt (from 3.0), and in depends/relic/CMakeLists.txt (from 3.1).
  • No changes to build steps beyond runner version and minimum CMake requirements; no source code or public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title precisely describes the main change by stating that the src/dashbls dependency is being updated to a specific commit of dashpay/bls-signatures, matching the pull request’s core objective without including irrelevant information.
Description Check ✅ Passed The description provides context by linking to the related pull request, specifying the expected subtree hash, noting that no breaking changes are expected, and including a completed checklist, all of which directly relate to the dependency update changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2350339 and b31fd98.

📒 Files selected for processing (5)
  • src/dashbls/.github/workflows/build-test.yaml (1 hunks)
  • src/dashbls/configure.ac (1 hunks)
  • src/dashbls/depends/mimalloc/CMakeLists.txt (1 hunks)
  • src/dashbls/depends/mimalloc/test/CMakeLists.txt (1 hunks)
  • src/dashbls/depends/relic/CMakeLists.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/{crc32c,dashbls,gsl,immer,leveldb,minisketch,secp256k1,univalue}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Do not make changes under any circumstances to vendored dependencies in src/crc32c, src/dashbls, src/gsl, src/immer, src/leveldb, src/minisketch, src/secp256k1, src/univalue

Files:

  • src/dashbls/depends/mimalloc/test/CMakeLists.txt
  • src/dashbls/depends/mimalloc/CMakeLists.txt
  • src/dashbls/depends/relic/CMakeLists.txt
  • src/dashbls/configure.ac
🔇 Additional comments (5)
src/dashbls/depends/relic/CMakeLists.txt (1)

1-1: Dependency update: CMake version requirement updated.

The minimum CMake version has been updated from 3.1 to 3.14 as part of the upstream dependency update. This change aligns with the broader modernization of build requirements across the bls-signatures dependency.

As per coding guidelines, this vendored dependency file should only be updated through proper subtree merges, which this PR follows correctly.

src/dashbls/depends/mimalloc/CMakeLists.txt (1)

1-1: Dependency update: CMake version requirement updated.

The minimum CMake version has been updated from 3.0 to 3.14, consistent with the CMake modernization in other dependency files within this update.

src/dashbls/configure.ac (1)

2-2: Dependency update: Package version bumped to 1.3.6.

The libdashbls version has been updated from 1.3.5 to 1.3.6 as part of the upstream dependency update to dashpay/bls-signatures@dd683653.

src/dashbls/depends/mimalloc/test/CMakeLists.txt (1)

1-1: Dependency update: CMake version requirement updated.

The minimum CMake version has been updated from 3.0 to 3.14 in the test configuration, maintaining consistency with the main mimalloc CMakeLists.txt.

src/dashbls/.github/workflows/build-test.yaml (1)

25-25: Dependency update: CI runner updated to ubuntu-latest.

The GitHub Actions workflow has been updated to use ubuntu-latest instead of ubuntu-20.04. This change from upstream aligns with the updated CMake 3.14 requirement and ensures the CI uses a supported Ubuntu version.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

UdjinM6
UdjinM6 approved these changes Oct 14, 2025
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b31fd98

PastaPastaPasta
PastaPastaPasta approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b31fd98

@PastaPastaPasta PastaPastaPasta merged commit 07518ff into dashpay:develop Oct 14, 2025
28 of 32 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst Awaiting requested review from knst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

23

Development

Successfully merging this pull request may close these issues.

3 participants

@kwvg @UdjinM6 @PastaPastaPasta