Fix bug that prevented new blocks to update tip during mixing#706
Closed
UdjinM6 wants to merge 1 commit intodashpay:v0.12.1.xfrom
UdjinM6:fixNoNewBlocks
Closed
Fix bug that prevented new blocks to update tip during mixing#706UdjinM6 wants to merge 1 commit intodashpay:v0.12.1.xfrom UdjinM6:fixNoNewBlocks
UdjinM6 wants to merge 1 commit intodashpay:v0.12.1.xfrom
UdjinM6:fixNoNewBlocks
Conversation
|
Nice catch - does it make sense to backport this to 0.12.0.x? As it seems the hangups during mixing are quite annoying... |
Author
|
Yep, I guess it makes sense. |
schinzelh
pushed a commit
that referenced
this pull request
Mar 2, 2016
|
Merged, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ugh.. I think I finally found it (again, but this time it should be the very last time) :)
The issue was caused by
pnode->fDisconnect = trueinCMasternodeMan::ProcessMasternodeConnections().ConnectNode()increments reference count and we should just decrease it (via callingRelease()) at the right time instead of changing flag directly. Otherwise some cleanup code was never triggered and we were stalling forever. To avoid situation when we could decrease it multiple times (which not only doesn't make sense but also that would trigger assert), flagpnode->fDarkSendMastershould also be set tofalse.I also added
Release()to some other parts of our code and fixed the wayConnectNode()is called there (true->false, see notes at https://github.com/dashpay/dash/compare/v0.12.1.x...UdjinM6:fixNoNewBlocks?expand=1#diff-1a8b9d1ad0a6fda5e751286c73102fc2R358)