Skip to content

chore: update minimum masternode peer version#7138

Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom
kwvg:vbump_v23.1
Feb 13, 2026
Merged

chore: update minimum masternode peer version#7138
PastaPastaPasta merged 1 commit intodashpay:developfrom
kwvg:vbump_v23.1

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Feb 13, 2026

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 23.1 milestone Feb 13, 2026
PastaPastaPasta
PastaPastaPasta approved these changes Feb 13, 2026
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, the instantsend improvements are valuable enough to have MNs kindly force other MNs to upgrade.

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Walkthrough

The pull request updates the minimum masternode protocol version constant in src/version.h from 70238 to 70240. This is a single-line change that aligns the minimum masternode protocol version with related version constants in the file. No logic modifications or functional changes are introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the minimum masternode protocol version constant from 70238 to 70240.
Description check ✅ Passed The description documents a completed checklist relevant to the changeset, confirming the author's self-review and compliance with repository standards.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@PastaPastaPasta PastaPastaPasta merged commit 9b61472 into dashpay:develop Feb 13, 2026
36 of 37 checks passed
UdjinM6
UdjinM6 approved these changes Feb 13, 2026
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0d89cc9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst Awaiting requested review from knst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

23.1

Development

Successfully merging this pull request may close these issues.

3 participants

@kwvg @UdjinM6 @PastaPastaPasta