feat: bump withdrawals limit in DIP0027 to 4k#165
Merged
thephez merged 1 commit intodashpay:masterfrom May 21, 2025
Merged
Conversation
5 tasks
PastaPastaPasta
approved these changes
May 7, 2025
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Concept ACK; I see no reason to not increase this in accordance with previous versions. This continues the trend from 1k initially to 2k, now to 4k.
knst
approved these changes
May 7, 2025
thephez
reviewed
May 7, 2025
| As a way to avoid a catastrophic failure if Platform is compromised, Core will limit credit pool withdrawals for at least the first release of Platform. The withdrawal limits may be re-evaluated and updated periodically as the system matures. To evaluate withdrawal validity, withdrawal amounts from the last 576 blocks should be tallied. The withdrawal should not be mined if: | ||
|
|
||
| * It requests more DASH than the credit pool contains | ||
| * The withdrawal would result in more than a 4000 DASH reduction in the credit pool over the past 576 blocks |
Collaborator
There was a problem hiding this comment.
We should consider moving the limits into a table with either this update or the next one. We're getting enough entries where that will make sense.
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 9, 2025
274000a feat: implement a fork to double withdrawals limit (UdjinM6) Pull request description: ## Issue being fixed or feature implemented Implements dashpay/dips#165 ## What was done? Bump the limit via new fork, add tests ## How Has This Been Tested? run test ## Breaking Changes n/a ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: kwvg: utACK 274000a Tree-SHA512: 522224bf4770f64c887655dcc283dd7f729999338066af7c4211a77608222e370ac6154e4112fb476f1326555b38b2cf841f41a0998998ecdd641eb542adbbd0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping the limit for the upcoming version.