Added support for provider Directnic#726
Merged
rhansen merged 2 commits intoddclient:masterfrom Aug 7, 2024
Merged
Conversation
701a9e5 to
bf21d85
Compare
rhansen
requested changes
Aug 3, 2024
Member
rhansen
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Member
|
If you want to add tests (not required, but appreciated), you can use |
bf21d85 to
0c3113c
Compare
jeffrego
commented
Aug 5, 2024
044b36d to
bc2b477
Compare
rhansen
requested changes
Aug 6, 2024
Member
rhansen
left a comment
There was a problem hiding this comment.
Looking good!
Would you mind rebasing the commits into two commits:
- 1st commit: add
T_URLtype and tests - 2nd commit: new
directnicprotocol
ff6321c to
c858dd9
Compare
c858dd9 to
959b5dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Directnic (https://directnic.com).
Documentation of the API is available at https://directnic.com/knowledge#/knowledge/article/3726
Configuration snippet for this provider:
password is the secret part of the update URL, e.g. for the example from their docs https://directnic.com/dns/gateway/ad133743f001e318e455fdc04/?data= you would set
password=ad133743f001e318e455fdc04Directnic assigns a unique token to every dynamic DNS entry, so if you have multiple records (like an A record and a AAAA record) for the same domain, each will get its own token and will need to be managed separately.