Enable arguments on cmdv4 and cmdv6#766
Merged
rhansen merged 3 commits intoddclient:mainfrom Jan 10, 2025
Merged
Conversation
Member
|
This might include cases that require more testing. |
e082706 to
591904c
Compare
rhansen
approved these changes
Jan 9, 2025
Member
There was a problem hiding this comment.
@greenius I rebased your commit onto latest main and pushed a fixup to refine your commit's message and eliminate an unnecessary variable. Would you mind reviewing it and letting me know if it looks OK to you? If so, I'll autosquash the two commits and merge.
Closed
Author
|
Amendment looks good to me. |
`quotemeta` prevents executing commands with arguments. With this
change, it is now possible to get an IP address with:
usev4=cmdv4
cmdv4="dig +short myip.opendns.com @resolver1.opendns.com"
591904c to
6fd9a6f
Compare
M1cha
added a commit
to M1cha/router
that referenced
this pull request
Dec 5, 2025
This allows specifying argument for cmdv4 and cmdv6, which I'll need soon. ddclient/ddclient#766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not call
quotemetaoncmdv4andcmdv6arguments as it prevents executing commands with arguments. eg. it is now possible to get an IP address with:Fixes #736