Remove unused import of ssl.OP_ENABLE_MIDDLEBOX_COMPAT#1601
Merged
jeffra merged 1 commit intodeepspeedai:masterfrom Nov 30, 2021
Merged
Remove unused import of ssl.OP_ENABLE_MIDDLEBOX_COMPAT#1601jeffra merged 1 commit intodeepspeedai:masterfrom
ssl.OP_ENABLE_MIDDLEBOX_COMPAT#1601jeffra merged 1 commit intodeepspeedai:masterfrom
Conversation
aphedges
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An import of
ssl.OP_ENABLE_MIDDLEBOX_COMPATwas added in commit 9caa74e, even though it is never used in the file. Although I can't tell why it was added originally, it does not seem to serve any purpose now.The constant was not introduced until Python 3.8, and it is "only available with OpenSSL 1.1.1 and later". I am running a version of Python 3.9 on CentOS 7, which has OpenSSL 1.0.2 by default, so just having this import causes
deepspeedto crash on import.