Remove hardcoded ROCm install path#2093
Merged
mrwyattii merged 5 commits intodeepspeedai:masterfrom Jul 19, 2022
Merged
Conversation
mrwyattii
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
awan-10,
cli99,
conglongli,
duli2012,
eltonzheng,
jeffra,
minjiaz,
samadejacobs,
samyam,
tjruwase,
xiaoxiawu-microsoft and
yaozhewei
as code owners
This was referenced Jul 13, 2022
jeffra
approved these changes
Jul 18, 2022
Contributor
|
I've seen test failures like this before when working on my PRs. There are some flaky tests that assume a certain execution time, and the threshold seems to be low enough to cause these intermittent failures. |
Contributor
Author
@aphedges yes, we've been noticing them more frequently too. We may increase the allowed threshold, but usually rerunning the tests will allow all inference tests to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2080