Add flops profiler tutorial#682
Merged
cli99 merged 65 commits intodeepspeedai:masterfrom Feb 11, 2021
Merged
Conversation
cli99
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
samyam
reviewed
Feb 3, 2021
| ) | ||
| (transformer): ParallelTransformer( | ||
| 12.61 M, 32.43% Params, 103.62 GMACs, 100.00% MACs, 4.4 ms, 13.22% time, 4.7e+01 TFLOPS, | ||
| (layers): ModuleList( |
Contributor
There was a problem hiding this comment.
Why is time percent and TFlops 0 for ModuleList?
samyam
reviewed
Feb 3, 2021
| model = models.alexnet() | ||
| batch_size = 256 | ||
| macs, params, steps = get_model_profile(model, # the PyTorch model to be profiled | ||
| macs, params = get_model_profile(model=model, # model |
Contributor
There was a problem hiding this comment.
It would be good to how how the model is called without the profiling so that the input_res and input_consturctors are clearer. Maybe have:
if profile:
macs, params = get_model_profile
else:
output/loss = model(....)
samyam
reviewed
Feb 3, 2021
| macs, params, steps = get_model_profile( | ||
| batch_size = 5 | ||
| seq_len = 128 | ||
| macs, params = get_model_profile( |
Contributor
There was a problem hiding this comment.
It would be good to how how the model is called without the profiling so that the input_res and input_consturctors are clearer. Maybe have:
if profile:
macs, params = get_model_profile
else:
output/loss = model(....)
Contributor
Author
There was a problem hiding this comment.
Made changes as suggested
samyam
reviewed
Feb 3, 2021
| # Output: | ||
| # Number of multiply-adds: 21.74 GMACs | ||
| # Number of parameters: 109.48 M | ||
| Below is an example of this usage in a typical training workflow. |
Contributor
There was a problem hiding this comment.
In this mode, is the profiler capturing only the forward, or forward backward and step? Can we make this more explicit?
Contributor
Author
There was a problem hiding this comment.
The profiler only captures the forward. I clarify this through the README.
samyam
reviewed
Feb 3, 2021
samyam
reviewed
Feb 3, 2021
samyam
approved these changes
Feb 10, 2021
sdtblck
added a commit
to EleutherAI/DeeperSpeed
that referenced
this pull request
Feb 11, 2021
* Dist testing backend fixes, etc. (deepspeedai#708) * set_batch_fn and remove old sanity check (deepspeedai#712) * properly set engine.local_rank if it's set to -1 * Add executable permission to `ds_elastic` and `ds_report` in `bin`. (deepspeedai#711) * Add executable permission to `ds_elastic` and `ds_report` in `bin`. * Automatic `ds_elastic` formatting Co-authored-by: Jeff Rasley <[email protected]> * local rank of -1 means not set (deepspeedai#720) * bump to 0.3.11 * [launcher] look ma, no more zombies (deepspeedai#714) Co-authored-by: Jeff Rasley <[email protected]> * Improve starred expressions (deepspeedai#696) * Improve starred expressions `deepspeed/profiling/flops_profiler/profiler.py` uses starred expressions that are no longer valid with [PEP 617][1]. The new Python parser is in 3.9, and this change allows DeepSpeed to run with the newest Python version. I have not checked all locations that has this issue. However, this change allows me to run simple examples. [1]: https://www.python.org/dev/peps/pep-0617/ * Match style for "Improve starred expressions", although readability suffers The style guide might need to be updated for this new use case of expressions. Python [Issue 40631][1] includes more discussion on the change. [1]: https://bugs.python.org/issue40631 Co-authored-by: Cheng Li <[email protected]> * Fixed typo in Readme. (deepspeedai#737) * 1bit_adam dependencies (deepspeedai#742) * Clickable screenshots (deepspeedai#746) * Fix docstring * Make screenshots clickable for easier viewing * Add flops profiler tutorial (deepspeedai#682) * work on flops profiler tutorial * update flops profiler tutorial * add flops profiler tutorial and fix names * work on flops profiler tutorial * update flops profiler tutorial * add flops profiler tutorial and fix names * fix tailing ws * fix names * remove multistep profiling and update docs * fix cases where functionals and submodules coexist in a parent module, update readme * fix typo * always invoke post hook function * fix module flops sum and update tests * update tutorial * Only initialize distributed if required (deepspeedai#734) Co-authored-by: Jeff Rasley <[email protected]> Co-authored-by: Jeff Rasley <[email protected]> Co-authored-by: Shaden Smith <[email protected]> Co-authored-by: Jon Eyolfson <[email protected]> Co-authored-by: Stas Bekman <[email protected]> Co-authored-by: Cheng Li <[email protected]> Co-authored-by: TheDudeFromCI <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Co-authored-by: Sean Naren <[email protected]>
B06901052
pushed a commit
to B06901052/DeepSpeed
that referenced
this pull request
Apr 14, 2022
* work on flops profiler tutorial * update flops profiler tutorial * add flops profiler tutorial and fix names * work on flops profiler tutorial * update flops profiler tutorial * add flops profiler tutorial and fix names * fix tailing ws * fix names * remove multistep profiling and update docs * fix cases where functionals and submodules coexist in a parent module, update readme * fix typo * always invoke post hook function * fix module flops sum and update tests * update tutorial
B06901052
pushed a commit
to B06901052/DeepSpeed
that referenced
this pull request
Apr 14, 2022
* work on flops profiler tutorial * update flops profiler tutorial * add flops profiler tutorial and fix names * work on flops profiler tutorial * update flops profiler tutorial * add flops profiler tutorial and fix names * fix tailing ws * fix names * remove multistep profiling and update docs * fix cases where functionals and submodules coexist in a parent module, update readme * fix typo * always invoke post hook function * fix module flops sum and update tests * update tutorial
|
In the inference module, can I add the performance analysis tutorial of llama2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the flops profiler tutorial, configuration, and feature to the website. Also fixed names of some flops profiler function parameters.