fix splt shape < 64 issue & add num_kv_heads to mp_params#33
Merged
delock merged 1 commit intodelock:gma/run-opt-branchfrom Nov 21, 2023
Merged
Conversation
Yejing-Lai
commented
Nov 21, 2023
Yejing-Lai
commented
- When split shape(total_size) < 64, tp sharding will fail. We have added support for split_shape < 64.
- falcon-40b will fail on SNC3. This reason is falcon-40b kv_head_names is "num_kv_heads". Need to add this name in mp_param list and kv_head_names list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.