Add --output option to devcontainer build#166
Add --output option to devcontainer build#166chrmarti merged 16 commits intodevcontainers:mainfrom natescherer:feature/add-output-options
Conversation
|
@microsoft-github-policy-service agree |
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left a few comments for changes / discussion.
|
Both requested changes have been committed. Hopefully the test works; I was not able to get yarn test to work in my local env for reasons I couldn't quite figure out. |
natescherer
changed the title
|
Previous test failed due to unbalanced quotes, looks like. Latest commit should fix it. |
|
@natescherer There are some test failures. Could you look into these? The change looks good otherwise. |
|
Looks like I was using a non-Dockerfile config to try and run the test which wouldn't work. Changed it and hopefully the test will pass now! |
|
@chrmarti Could you please trigger the tests again when you get a minute? Looks like they don't automatically run, probably since I'm a first-time contributor to this repo. |
|
Looks like synchronizing from main caused there to be a missing comma. Last commit should fix. |
|
@chrmarti Looks like the local environment on the machine running the tests was using the default docker buildx driver. Added wrapper to create a new buildx driver at the start of the test and then reset to the default driver after. Hopefully this will get that test to pass now. |
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
@natescherer looks like there are some merge conflicts. Could you help resolve them? thanks!
|
@samruddhikhandale I re-merged main with my branch, should be good now hopefully! |
|
@natescherer Merged, thanks! |
3 participants
This is related to what was discussed in #155.
This PR adds new options
--output-typeand--output-destthat pass through todocker buildx build --output.If there's anything that needs added or changed, please let me know!