Rollback go and controller runtime versions#16
Merged
thepetk merged 4 commits intodevfile:bck/1.1.0from Aug 4, 2023
Merged
Conversation
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
thepetk
changed the title
Contributor
Author
|
I've created the PR temporarily to point to main in order to check if all actions are passing. After everything all tests are passing I'll point back to |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## bck/1.1.0 #16 +/- ##
==========================================
Coverage 66.56% 66.56%
==========================================
Files 10 10
Lines 1358 1358
==========================================
Hits 904 904
Misses 394 394
Partials 60 60 ☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <[email protected]>
thepetk
changed the title
Contributor
Author
All tests are passing - I've pointed back to |
mike-hoang
approved these changes
Aug 4, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mike-hoang, thepetk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
thepetk
referenced
this pull request
in thepetk/devfile-alizer
Sep 20, 2023
* Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
thepetk
added a commit
that referenced
this pull request
Sep 20, 2023
* Rollback go and controller runtime versions (#16) * Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Update go version to 1.19 Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
thepetk
added a commit
that referenced
this pull request
Oct 4, 2023
* Rollback go and controller runtime versions (#16) * Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Update go version to 1.19 Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
thepetk
added a commit
that referenced
this pull request
Oct 4, 2023
* Rollback go and controller runtime versions (#16) * Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Update go version to 1.19 Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR rolls back
goto version1.18andcontroller-runtimetov0.14.4.We will not be using the
mainbranch for this version, instead we will be using thebck/1.1.0.Once the
application-apiupdates its version of go to1.19we will deprecate the backported tag.Which issue(s) does this PR fix
fixes devfile/api#1210
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer