add java jakarta ee framework detection support#303
Conversation
|
Hi @thepetk @Jdubrick @elsony @michael-valdron kindly reqeust your review on this PR. Thanks! |
Signed-off-by: bzssm <[email protected]>
bzssm
force-pushed
the
royyang/add-jakartaee-support
branch
from
a8c0f8c to
7fb4963
Compare
Signed-off-by: bzssm <[email protected]>
|
Hi @thepetk , thanks for the feedback! Please take another look when you have a chance. Thanks! |
|
@bzssm looks good in general, it only needs a rebase after we have merged another PR. Thanks! |
|
@thepetk rebased. Can you please help to review again? Thanks! |
Might need another rebase cause we had some PRs opened in parallel. Thanks! |
|
@thepetk Rebased. Can you please help to review again? Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bzssm, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description of Changes
add java jakarta ee framework detection support
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.