-
Notifications
You must be signed in to change notification settings - Fork 74
Closed as not planned
Labels
2023Q3area/alizerEnhancement or issue related to the alizer repoEnhancement or issue related to the alizer repoarea/documentationImprovements or additions to documentationImprovements or additions to documentationdemoIssue or PR candidate for a demo at the end of the SprintIssue or PR candidate for a demo at the end of the Sprintlifecycle/rottenRotten items. These items have been stale for 60 days and are now closed.Rotten items. These items have been stale for 60 days and are now closed.lifecycle/staleStale items. These items have not been updated for 90 days.Stale items. These items have not been updated for 90 days.
Description
Which area/kind this issue is related to?
/area alizer
/area documentation
Issue Description
This issue is part of the #1154 EPIC and focuses on the default_ports per framework we need to define. That said for each framework detector (e.g laravel_detector.go) we should define default ports. A good way could be to define a function GetDefaultPorts inside each detector:
func (d LaravelDetector) GetDefaultPorts() []string {
return []int{8080}
}If the user has included a flag --add-default-ports, if no port value is detected during port detection we can return those ports. Finally, additions to the existing documentation should be made.
Acceptance Criteria
- A new flag
--add-default-portsis created - Every detector should have defined default ports
- Every detector should return default ports if
--add-default-portsexists and no ports have been defined. - Test cases to ensure the above criteria
- Update documentation (port detection especially) to mention this update.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
2023Q3area/alizerEnhancement or issue related to the alizer repoEnhancement or issue related to the alizer repoarea/documentationImprovements or additions to documentationImprovements or additions to documentationdemoIssue or PR candidate for a demo at the end of the SprintIssue or PR candidate for a demo at the end of the Sprintlifecycle/rottenRotten items. These items have been stale for 60 days and are now closed.Rotten items. These items have been stale for 60 days and are now closed.lifecycle/staleStale items. These items have not been updated for 90 days.Stale items. These items have not been updated for 90 days.
Type
Projects
Status
Done ✅