Merge meta.yaml and devfile.yaml#248
Conversation
Signed-off-by: jingfu wang <[email protected]>
Signed-off-by: jingfu wang <[email protected]>
Signed-off-by: jingfu wang <[email protected]>
Agree, let me ask some folks to review it. |
|
|
||
| // Optional devfile global memory limit | ||
| // +optional | ||
| GlobalMemoryLimit string `json:"globalMemoryLimit,omitempty"` |
There was a problem hiding this comment.
I'm not sure if GlobalMemoryLimit is needed (but I'm also not opposed to adding it). The story behind this field is that we needed a way to get the total memory required by a workspace, and this was hard to do from a very simple registry -- plugin memory requirements are stored in their own meta.yamls and can change arbitrarily while the devfile registry is running, and further the devfile itself can override the values set in the plugin. This field is manually set by the devfile author to smooth a use-case in Che, but the value here can drift apart from reality (if e.g. one of your plugins updates and starts using more memory).
I wonder if the new devfile registry could offer some metrics/calculation to get this number directly without user input?
There was a problem hiding this comment.
Thanks for bringing that up, AFAIK currently the new devfile registry/OCI devfile registry doesn't provide a mechanism to directly get the number of global memory limit, so for the timing being, let's still add this field. Given this PR is only for purely migrating fields from meta.yaml, I think we can merge this PR for now, then open separate issue to discuss the existence of the specific field if it's needed as I think that may or may not bring more discussion and design.
sleshchenko
left a comment
There was a problem hiding this comment.
Nothing to add apart from Angel's comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, GeekArthur, johnmcollier, sleshchenko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: jingfu wang [email protected]
What does this PR do?
This PR adds new metadata fields to the existing devfile schema so that we can merge meta.yaml and devfile.yaml
What issues does this PR fix or reference?
Fixes #172
Is your PR tested? Consider putting some instruction how to test your changes