Add contributions field to the DevWorkspace custom resource#879
Merged
amisevsk merged 2 commits intodevfile:mainfrom Sep 13, 2022
Merged
Add contributions field to the DevWorkspace custom resource#879amisevsk merged 2 commits intodevfile:mainfrom
amisevsk merged 2 commits intodevfile:mainfrom
Conversation
Add field `.spec.contributions` to the DevWorkspace custom resource to allow specifying additional resources (e.g. editors, etc.) that should be included in a DevWorkspace. This allows for adding additional components to a workspace while using the .spec.template field to store a devfile. Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
9 tasks
amisevsk
changed the title
l0rd
approved these changes
Jul 27, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, l0rd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Implements new field in DevWorkspace custom resource
.spec.contributionsaccording to #874. See issue for details on design/reasoning.This PR basically copies fields from the existing pluginComponent into a new field in the DevWorkspace CR.
Which issue(s) this PR fixes:
Closes #874
How to test changes / Special notes to the reviewer: