feat: use endpoint names as container port names if they shorter than 16 characters#736
Merged
amisevsk merged 2 commits intodevfile:mainfrom Jan 17, 2022
Merged
Conversation
Reuse the endpoint name as the port name in a workspace container if it fits the pod spec for a port name (max length = 15 chars). If an endpoint name is longer than 15 chars, fallback to previous functionality of formatting <portNum>-<protocol>. In the case of duplicated ports in one container with short names, use the name from the first port. Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
Merged
4 tasks
ibuziuk
approved these changes
Jan 14, 2022
Contributor
ibuziuk
left a comment
There was a problem hiding this comment.
👍
just need to fix the semantic pull request check
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
test v8-devworkspace-operator-e2e |
Collaborator
|
/test v8-devworkspace-operator-e2e, v8-che-happy-path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reuse endpoint name as container port name if it is short enough (<=15 chars). Otherwise, use current format (
<portnum>-<protocol>).What issues does this PR fix or reference?
Container port names can be confusing
Is it tested? How?
Test cases are added. Functionality should not change as workspace services refer to ports by number and not name.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheAdditional info