Added devfile registry docs#73
Added devfile registry docs#73rkratky merged 21 commits intodevfile:masterfrom jc-berger:jcberger_191_devfileregistry
Conversation
johnmcollier
left a comment
There was a problem hiding this comment.
Generally looks fine to me. Just left a couple small comments
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
|
@johnmcollier if you could take another look and give it the LGTM if you think it looks good. Apologies for the many commits...I accepted Rolfe's changes than made several myself, resulting in lots of commits! Thanks for the help! |
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
rolfedh
left a comment
There was a problem hiding this comment.
One minor comment. Otherwise, /lgtm
|
@rolfedh: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rkratky gotten the LTM from docs and devs. Please let me know if there's anything you would like me to address or change before you merge, thanks! |
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
|
@rkratky, addressed your comment and made some more changes in my new commit. Also, you'll see a comment I made pointing out the many uses of passive voice. If you think it all looks fine, please go ahead and merge. Otherwise, I'm happy to continue to make changes. Thanks! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, johnmcollier, rkratky, rolfedh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #191 Define onboarding requirement
Taking content from John's devfile-registry docs repo: https://github.com/johnmcollier/registry-docs
I've left comments throughout the docs, asking questions to help direct peer reviewers' attention.
Thanks!
@johnmcollier or @GeekArthur would either of you take a look please to see how the devfile registry docs are looking?