Conversation
Signed-off-by: Stephanie <[email protected]>
|
@mohammedzee1000 Can you help review the PR to see if this is what Odo looking for? |
mohammedzee1000
left a comment
There was a problem hiding this comment.
yep. this is what odo id looking for.
Eventually (once openshift 3.11 is phased out), we should no longer need generator for extensions v1 beta1 ingress, but for now, this looks good
|
@mohammedzee1000: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, mohammedzee1000, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie [email protected]
What does this PR do?
This PR introduced a new function to get networking.k8s.io/v1 ingress, since v1beta1 ingress is no longer supported in future versions of k8s api
What issues does this PR fix or reference?
Fixes devfile/api#504
Is your PR tested? Consider putting some instruction how to test your changes
Added new unit test