Merged
Conversation
Signed-off-by: Stephanie <[email protected]>
yangcao77
force-pushed
the
521-removeDevfileJSONWriter
branch
from
23de64b to
d14f8c9
Compare
maysunfaisal
approved these changes
Jun 30, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie <[email protected]>
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie [email protected]
What does this PR do?
This issue resolves a few small issues in library.
it picks the latest API pkg with the fix for devfile/api#500
it fixes a typo in util.go,
retrive->retrieveit removes the
WriteJsonDevfile()function, since we never officially support devfile.json, and no one is consuming that function now. so remove to avoid confusion.What issues does this PR fix or reference?
Fixes devfile/api#521
Fixes devfile/api#520
Fixes devfile/api#500
Is your PR tested? Consider putting some instruction how to test your changes
remove json writer test, and update the unit test name to be yaml writer.