error out if import devfile version is greater than child#125
error out if import devfile version is greater than child#125yangcao77 merged 1 commit intodevfile:mainfrom
Conversation
Signed-off-by: Stephanie <[email protected]>
kim-tsao
left a comment
kim-tsao
left a comment
There was a problem hiding this comment.
This is outside the PR, but should we open up a doc issue to explain this behaviour?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I understand the concern, but we currently do not have any doc for the errors. I'm not sure if we want to doc all error behaviors. |
I was thinking about having a section for version compatibility wrt to parent/plugin overriding or maybe documenting this as a limitation. Users may assume full interoperability otherwise. |
I will merge this PR, and issue created to track the doc change required: devfile/api#694 |
2 participants
Signed-off-by: Stephanie [email protected]
What does this PR do?:
This PR compares the version of parent/plugin devfile with it's child devfile, and error out if greater than child devfile version.
Which issue(s) this PR fixes:
Fixes devfile/api#686
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: