Merged
Conversation
Signed-off-by: Stephanie <[email protected]>
Member
johnmcollier
left a comment
johnmcollier
left a comment
There was a problem hiding this comment.
Left on suggestion, otherwise looks good.
CONTRIBUTING.md
Outdated
Comment on lines
+60
to
+61
| ## Code of Conduct | ||
| See [contributor code of conduct](https://github.com/devfile/api/blob/main/CODE_OF_CONDUCT.md#contributor-covenant-code-of-conduct) No newline at end of file |
Member
There was a problem hiding this comment.
Would suggest moving this up to the top. and maybe prefix it with a "Before contributing to this repository see contributor code of conduct"
Signed-off-by: Stephanie <[email protected]>
yangcao77
force-pushed
the
808-add-contributing-md
branch
from
8552cc0 to
0859034
Compare
johnmcollier
approved these changes
Mar 30, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie <[email protected]>
|
New changes are detected. LGTM label has been removed. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie [email protected]
What does this PR do?:
This PR creates contributing.md file
moves some "maintainer-need-to-know" information from README to contributing.md
Which issue(s) this PR fixes:
Fixes devfile/api#808
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: