External variables can override Devfile variables#136
Merged
elsony merged 2 commits intodevfile:mainfrom Jun 2, 2022
Merged
Conversation
Signed-off-by: Philippe Martin <[email protected]>
Collaborator
|
Do you mind adding a unit test case for the |
Contributor
Author
Sure, I'll add a unit test case |
Signed-off-by: Philippe Martin <[email protected]>
2 tasks
yangcao77
approved these changes
May 18, 2022
Collaborator
yangcao77
left a comment
yangcao77
left a comment
There was a problem hiding this comment.
changes look good to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR adds an
ExternalVariablesoption to theParserArgsstructure, to be able to override variables defined in the devfile with other values when parsing a Devfile.Which issue(s) this PR fixes:
redhat-developer/odo#5489
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: