proxy and custom timeout support#143
Merged
kim-tsao merged 1 commit intodevfile:mainfrom Sep 13, 2022
Merged
Conversation
Signed-off-by: Kim Tsao <[email protected]>
maysunfaisal
approved these changes
Sep 12, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kim Tsao [email protected]
What does this PR do?:
Adds proxy support for the util.GetHTTPRequest method and allows clients to specify a custom http timeout value
Which issue(s) this PR fixes:
devfile/api#926
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Relying on console team to test
Documentation
Client Impact
These changes are needed in order to fix a bug on the console.
How to test changes / Special notes to the reviewer: