Filesystem is not required when reading from URL and Data#149
Filesystem is not required when reading from URL and Data#149maysunfaisal merged 1 commit intodevfile:mainfrom
Conversation
Signed-off-by: Maysun J Faisal <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportBase: 58.20% // Head: 58.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 58.20% 58.24% +0.03%
==========================================
Files 35 35
Lines 3965 3968 +3
==========================================
+ Hits 2308 2311 +3
Misses 1518 1518
Partials 139 139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 participants
Signed-off-by: Maysun J Faisal [email protected]
What does this PR do?:
Updated the method param to a nil, because a Filesystem is not required to be passed in if the src is URL or Data
Which issue(s) this PR fixes:
N/A, but suggested in review here openshift/console#12000 (comment)
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Tests updated and should run successfully