Conversation
Signed-off-by: Kim Tsao <[email protected]>
Codecov ReportBase: 58.95% // Head: 58.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 58.95% 58.68% -0.28%
==========================================
Files 36 36
Lines 4037 4066 +29
==========================================
+ Hits 2380 2386 +6
- Misses 1518 1541 +23
Partials 139 139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kim-tsao
requested review from
yangcao77
and removed request for
elsony and
maysunfaisal
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Signed-off-by: Kim Tsao [email protected]
What does this PR do?:
devfile-libraryso we can distinguish these events betterWhich issue(s) this PR fixes:
devfile/api#981
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Will raise this in the community call/slack channel
How to test changes / Special notes to the reviewer:
Corresponding changes were made on the registry-support repo and deployed to a local cluster for testing. Confirmed telemetry is not collected on parent references and intended events have the new client identifier
devfile-library