Add support for container-overrides attribute#157
Conversation
valaparthvi
force-pushed
the
container-overrides
branch
from
76c2dfd to
b929467
Compare
Codecov ReportBase: 58.68% // Head: 59.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 58.68% 59.04% +0.35%
==========================================
Files 36 36
Lines 4066 4131 +65
==========================================
+ Hits 2386 2439 +53
- Misses 1541 1549 +8
- Partials 139 143 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valaparthvi
force-pushed
the
container-overrides
branch
from
71adc5e to
0e8c73d
Compare
valaparthvi
requested review from
maysunfaisal
and removed request for
elsony and
kim-tsao
|
@maysunfaisal What do I do about coverage? Would you suggest I add unit tests covering them? |
|
@valaparthvi yes that would be ideal and nice |
valaparthvi
force-pushed
the
container-overrides
branch
from
e675216 to
c891613
Compare
valaparthvi
force-pushed
the
container-overrides
branch
from
c891613 to
eef14aa
Compare
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
container-overrides
branch
from
eef14aa to
10f90da
Compare
Signed-off-by: Parthvi Vala <[email protected]>
| patched, err := containerOverridesHandler(comp, container) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| containers = append(containers, *patched) |
There was a problem hiding this comment.
can we add a test case with attributes to cover this? I think we can add one to TestGetContainers
valaparthvi
force-pushed
the
container-overrides
branch
from
c0fab84 to
9f99a24
Compare
…sHandler to check for error strings Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
container-overrides
branch
from
9f99a24 to
947b122
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
What does this PR do?:
Adds support for container-overrides attribute, as described in devfile/api#920 (comment).
The logic for this PR is motivated by devfile/devworkspace-operator#967.
Which issue(s) this PR fixes:
Fixes part of devfile/api#936
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Will work on docs once the PR is approved.
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Override fields such as securityContext or resources of container by using
components[*].container.attributesfield.Use the examples in devfile/api#920 (comment).