Fix pod-overrides for container level#162
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Parthvi Vala <[email protected]>
67eaaa8 to
0e18623
Compare
|
New changes are detected. LGTM label has been removed. |
|
@kim-tsao I had to rebase my branch onto main to fix the Build action for the PR. Can you re-lgtm? |
Codecov ReportBase: 59.55% // Head: 59.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 59.55% 59.67% +0.11%
==========================================
Files 36 36
Lines 4226 4226
==========================================
+ Hits 2517 2522 +5
+ Misses 1562 1557 -5
Partials 147 147
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Parthvi Vala [email protected]
What does this PR do?:
This PR fixes a faulty behavior when pod-overrides is defined at container level.
Which issue(s) this PR fixes:
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation (Add documentation for pod-overrides and container-overrides attributes devfile-web#70)
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
1. Use the following Devfile:
odo devkubectl get po my-node-app-xxx -ojsonpath='{.spec.serviceAccountName}'; it should benew-service-account.