Skip to content

Remove the error wrapping for reading K8s/OpenShift YAMLs#164

Merged
maysunfaisal merged 1 commit intodevfile:mainfrom
maysunfaisal:updateErrorMsg-1
Feb 16, 2023
Merged

Remove the error wrapping for reading K8s/OpenShift YAMLs#164
maysunfaisal merged 1 commit intodevfile:mainfrom
maysunfaisal:updateErrorMsg-1

Conversation

@maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Feb 16, 2023

What does this PR do?:

Removes the excessive error wrapping

For example, this is what we see in HAS:

Status:
  Conditions:
    Last Transition Time:  2023-02-16T21:49:29Z
    Message:               Component create failed: failed to parse kubernetes/openshift component from uri to inlined: failed to convert Kubernetes Uri to inlined for component 'kubernetes-only-deploy': error getting kubernetes resources definition info from url 'https://raw.githubusercontent.com/maysunfaisal/devfileexample/main/case4/nodeploy.yaml': failed to retrieve https://raw.githubusercontent.com/maysunfaisal/devfileexample/main/case4/nodeploy.yaml, 404: Not Found
    Reason:                Error
    Status:                False
    Type:                  Created

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from kim-tsao and yangcao77 February 16, 2023 22:06
@maysunfaisal maysunfaisal removed the request for review from kim-tsao February 16, 2023 22:06
@openshift-ci openshift-ci bot added the lgtm label Feb 16, 2023
@maysunfaisal
Remove the error wrapping
0e0d1b6 
Signed-off-by: Maysun J Faisal <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 59.67% // Head: 59.67% // No change to project coverage 👍

Coverage data is based on head (0e0d1b6) compared to base (4f0ff68).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files          36       36           
  Lines        4226     4226           
=======================================
  Hits         2522     2522           
  Misses       1557     1557           
  Partials      147      147
Impacted Files Coverage Δ
pkg/devfile/parser/parse.go 53.87% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci openshift-ci bot added the lgtm label Feb 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit f42f719 into devfile:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangcao77 yangcao77 yangcao77 approved these changes

Assignees

@yangcao77 yangcao77

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maysunfaisal @yangcao77